Skip to content

Make SamlResponse slightly more extendable#188

Merged
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom
AlexPayment:extendable
Sep 25, 2018
Merged

Make SamlResponse slightly more extendable#188
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom
AlexPayment:extendable

Conversation

@AlexPayment
Copy link
Copy Markdown
Contributor

@AlexPayment AlexPayment commented Sep 21, 2018

  • Fix some spelling issues
  • Update readme with latest version
  • Make SamlResponse a bit more extendable for when special validation logic is required
  • Fix a maven warning about maven-jar-plugin version missing

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 21, 2018

Coverage Status

Coverage increased (+0.02%) to 94.924% when pulling 5e82145 on AlexPayment:extendable into c15d3e7 on onelogin:master.

@pitbulk pitbulk merged commit 7f614e1 into SAML-Toolkits:master Sep 25, 2018
@pitbulk
Copy link
Copy Markdown
Contributor

pitbulk commented Sep 25, 2018

Nice contribution ;)

@AlexPayment
Copy link
Copy Markdown
Contributor Author

Thanks @pitbulk! When can we expect the next release?

@AlexPayment AlexPayment deleted the extendable branch September 25, 2018 20:40
@pitbulk
Copy link
Copy Markdown
Contributor

pitbulk commented Sep 25, 2018

Im working on pending Issues and PRs. After them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants